Handle string annotations in ScopeProvider #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Kronuz
force-pushed
the
annotation-access
branch
from
09f0418
to
fcd8564
Compare
jimmylai
reviewed
Aug 14, 2020
jimmylai
reviewed
Aug 14, 2020
Kronuz
force-pushed
the
annotation-access
branch
from
fcd8564
to
c1f7b80
Compare
jimmylai
reviewed
Aug 14, 2020
jimmylai
reviewed
Aug 14, 2020
jimmylai
approved these changes
Aug 14, 2020
Kronuz
force-pushed
the
annotation-access
branch
from
c1f7b80
to
fa15c98
Compare
zsol
reviewed
Sep 2, 2020
| value = node.evaluated_value | ||
| if value: | ||
| mod = cst.parse_module(value) | ||
| mod.visit(self) |
There was a problem hiding this comment.
There's a subtle problem with this approach that I only just discovered. Running self on another module will mean we'll collect CST nodes that don't appear in the original CST. That means anyone using these collected nodes will not be able to meaningfully use them (for example to look up other metadata for them, like position). I'll open a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for string annotations to ScopeProvider
Test Plan
Run tests