Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation access #372

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Annotation access #372

merged 1 commit into from
Aug 14, 2020

Conversation

Kronuz
Copy link
Contributor

@Kronuz Kronuz commented Aug 13, 2020

Summary

Access references with this type come from an annotation.

Test Plan

Run tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2020
@Kronuz Kronuz force-pushed the annotation-access branch 3 times, most recently from ce1ba4e to 741e4c3 Compare August 13, 2020 18:36
jimmylai
jimmylai approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments, LGTM.

libcst/metadata/scope_provider.py Outdated Show resolved Hide resolved
libcst/metadata/scope_provider.py Show resolved Hide resolved
@Kronuz
Add is_annotation subtype for Access inreferences.
85761b2 
Access references with this type come from an annotation.

(cherry picked from commit 39427ea)
@codecov-commenter
Copy link

Codecov Report

Merging #372 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files         231      231           
  Lines       22102    22119   +17     
=======================================
+ Hits        20788    20805   +17     
  Misses       1314     1314
Impacted Files Coverage Δ
libcst/metadata/scope_provider.py 96.83% <100.00%> (+0.04%) ⬆️
libcst/metadata/tests/test_scope_provider.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867f85e...85761b2. Read the comment docs.

@Kronuz Kronuz merged commit 81136d2 into master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylai jimmylai jimmylai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kronuz @codecov-commenter @jimmylai @facebook-github-bot