Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RemoveUnusedImports] Support string type annotations #353

Merged
merged 7 commits into from
Jul 31, 2020
Merged

[RemoveUnusedImports] Support string type annotations #353

merged 7 commits into from
Jul 31, 2020

Commits on Jul 28, 2020

  1. [RemoveUnusedImports] Support string type annotations 

    This PR adds support for detecting imports being used by string type
annotations, as well as imports suppressed by comments.

It breaks up the existing visitor into multiple smaller, single-purpose
visitors, and composes them together.
    @zsol
    zsol committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    187f249 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Address review feedback: 

    - move lint suppression out from visitor into codemod
- change suppression regex
    @zsol
    zsol committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    520abd0 View commit details
    Browse the repository at this point in the history

  2. lint

    @zsol
    zsol committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    f436658 View commit details
    Browse the repository at this point in the history

  3. fix type errors

    @zsol
    zsol committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a763d7c View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. review feedback

    @zsol
    zsol committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    6d23154 View commit details
    Browse the repository at this point in the history

  2. remove unused variable

    @zsol
    zsol committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    6e6037e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. add docs

    @zsol
    zsol committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    ee6c812 View commit details
    Browse the repository at this point in the history