Only remove trailing comma if the last alias is removed #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RemoveUnusedImportsVisitor
always removed trailing commas from import statements, which caused the CST to always change. This is undesirable because it causes unnecessary post-processing (like formatting being applied) even if there were no "real" changes to the CST.This PR changes visitor's behavior so that the trailing comma is only removed if the last alias is actually removed.
Test Plan
Added unit tests