Fix stdout being plugged into codemod-ed file #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running a codemod on a file, the output success message of
black
ended up embedded in the file itself. See image below:Tried to set the
-q
flag here to quiet the output but that ended up completely erasing the test fileRemoving the line of code in
libcst/codemod/_cli.py
did the trick. The file still gets reformatted and theblack
output message still ends up in the terminal. See image below:Test Plan
z.py
with various existing codemod commands--no-format
flag to ensure that when it's on,black
is not called at all