Function call with walrus loses colon in roundtrip #416
Comments
thatch
added a commit
to thatch/LibCST
that referenced
this issue
Nov 11, 2020
Previous behavior treated it as identical to equal, making a kwarg; it should instead be a positional arg. Includes several tests to make sure that whitespace handling is correct. Fixes Instagram#416
thatch
added a commit
to thatch/LibCST
that referenced
this issue
Nov 11, 2020
Previous behavior treated it as identical to equal, making a kwarg; it should instead be a positional arg. Includes several tests to make sure that whitespace handling is correct. Fixes Instagram#416
thatch
added a commit
to thatch/LibCST
that referenced
this issue
Nov 13, 2020
Previous behavior treated it as identical to equal, making a kwarg; it should instead be a positional arg. Includes several tests to make sure that whitespace handling is correct. Fixes Instagram#416
jimmylai
pushed a commit
that referenced
this issue
Nov 13, 2020
Previous behavior treated it as identical to equal, making a kwarg; it should instead be a positional arg. Includes several tests to make sure that whitespace handling is correct. Fixes #416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This input
is roundtripped as
due to a parse error.
I'm fairly certain the problem is the grammar on https://github.com/Instagram/LibCST/blob/master/libcst/_parser/conversions/expression.py#L1430 not matching namedexpr_test nor doing anything but AssignEqual in the else case. I tried to alter the grammar there to use namedexpr_test, but that caused ambiguity.
Going the other route to fix, we'll need another case to fix because this is the first positional arg, not a kwarg.
The text was updated successfully, but these errors were encountered: