-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start port over to the shared kzg lib #37
Conversation
cc: @terencechain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the deps.bzl file needs to be updated too using gazelle. I can do this later.
beacon-chain/core/blob/sidecar.go
Outdated
} | ||
return nil | ||
copy(kzgSidecar.BeaconBlockRoot[:], sidecar.BeaconBlockRoot) | ||
copy(kzgSidecar.KZGAggregatedProof[:], sidecar.AggregatedProof) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could simplify these using bytesutil.ToBytes48(proof)
on L48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, changed.
7245056
to
4e1cf09
Compare
looking into this. |
4e1cf09
to
00eb2cb
Compare
Ran the updates, and patched various bazel build issues. "bazel build //beacon-chain:beacon-chain" now runs successfully. |
* start port over to the shared kzg lib * have CL compute the aggregated proof for the block, per updated spec
* update to use latest kzg lib (#35) * Expose JSON GetBlock * start port over to the shared kzg lib (#37) * start port over to the shared kzg lib * have CL compute the aggregated proof for the block, per updated spec * start port over to the shared kzg lib (#37) (#38) * start port over to the shared kzg lib * have CL compute the aggregated proof for the block, per updated spec Co-authored-by: dancoffman <coffman@coinbase.com> Co-authored-by: Daniel Coffman <dgcoffman@gmail.com>
There is still code to be moved from Prysm into the shared lib, but this should at least update Prysm fully to the latest EIP-4844 spec changes. All devnet e2e tests pass when running with the similarly upgraded geth.