Clarify Contributor workbook question #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenucksi
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
I like those clarifications and they LGTM but would like to hint to another addition @Ludmila-N made in #122 (comment):
"Question 1, answer 4 has the explanation that was never mentioned in the video, suggest rewriting this option:" (Contributor section, Contributor Ethos)
Maybe we can get another commit on those before we merge it? Maybe we can rephrase it along the lines of "a proven pattern for this problem ist ... 30-days-of-warranty" or so?
Although not in the video, it is in the article, which we've said before is fair game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122