Skip to content

Commit

Permalink
[ES-1424] added null check
Browse files Browse the repository at this point in the history
Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com>
  • Loading branch information
pvsaidurga committed Aug 20, 2024
1 parent ef219db commit 5d4d165
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
import lombok.Data;

import io.mosip.esignet.core.validator.RedirectURL;

import javax.validation.Valid;
import javax.validation.constraints.NotBlank;

import static io.mosip.esignet.core.constants.ErrorConstants.INVALID_CLIENT_ID;
Expand Down Expand Up @@ -73,6 +75,7 @@ public class OAuthDetailRequest {
* The userinfo and id_token members of the claims request both are JSON objects with the
* names of the individual Claims being requested as the member names.
*/
@Valid
private ClaimsV2 claims;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import lombok.Data;
import lombok.NoArgsConstructor;

import javax.validation.Valid;
import java.io.Serializable;
import java.util.Map;

Expand All @@ -21,5 +22,5 @@ public class VerifiedClaimDetail implements Serializable {

private static final long serialVersionUID = 1L;
private VerificationFilter verification;
private Map<String, ClaimDetail> claims;
private Map<String,@Valid ClaimDetail> claims;
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public class PurposeValidator implements ConstraintValidator<Purpose, String> {

@Override
public boolean isValid(String purpose, ConstraintValidatorContext constraintValidatorContext) {
if(purpose==null) return true;
int length = StringUtils.hasText(purpose) ? purpose.length() : 0;
return length >= minLength && length <= maxLength;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void testIsValid_WithPurposeWithInvalidLength_thenFail() {
public void testIsValid_WithNullPurpose_theFail() {
String purpose = null;
boolean isValid = purposeValidator.isValid(purpose, constraintValidatorContext);
assertFalse(isValid);
assertTrue(isValid);
}

@Test
Expand Down

0 comments on commit 5d4d165

Please sign in to comment.