chore: update to ACA-Py 0.12.1 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
dbluhm
previously approved these changes
May 6, 2024
dbluhm
reviewed
May 6, 2024
pyproject.toml
Outdated
| @@ -6,7 +6,7 @@ authors = ["Colton Wolkins <colton@indicio.tech>", "Kim Ebert <kim@indicio.tech> | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9.0" | |||
| aries-cloudagent = {version = "^0.11.0", extras = ["askar"]} | |||
| aries-cloudagent = {version = "^0.12.1", extras = ["askar"]} | |||
There was a problem hiding this comment.
If no changes are required in ACA-Py cache redis to get this working on 0.12.1, then there's technically no need to change this version constraint in the pyproject.toml. We can just run a poetry update and it should update the lock file and that should be all we need.
There was a problem hiding this comment.
Because acapy-cache-redis (0.1.0) @ git+https://github.com/Indicio-tech/aries-acapy-cache-redis.git@HEAD depends on aries-cloudagent (^0.11.0)
and no versions of aries-cloudagent match >0.11.0,<0.12.0, acapy-cache-redis (0.1.0) @ git+https://github.com/Indicio-tech/aries-acapy-cache-redis.git@HEAD requires aries-cloudagent (0.11.0).
Given this error message @anwalker293 reported, this indicates that the version constraint needs to be tweaked. I recommend changing it to >=0.11.0,<1.0.0.
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
dbluhm
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.