-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add IsQuitting boolean, Quitting event, and StopOnQuit helper #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the coroutines, the event itself seems fine.
Are you sure the coroutines reliably get a chance to run after quitting starts?
If some coroutine needs to handle game quitting then it can add the condition by itself, having extra classes for this seems like an overkill with how niche this is.
I've done experiments and found that (at least in some cases) they continue running and the game waits for them to complete. I've updated most of my plugins to watch for quitting, but I'm pretty sure autosave is hanging studio shutdown with it's wait for X minutes (which is why I wanted to move this to someplace more common), so I figured something more generic rather than everyone writing similar code, but I can remove them. The other option is to just not use the
|
Removed extra classes and added single |
Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
Add support to detect/react to application quitting.
Plugins with long waits can cause game/studio to hang when quitting. Replace things like:
with:
and/or: