Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 1.42: "Screen Effect/Viewport/Content/Sky/Pattern/Dropdown" doesn't exist in KK #78

Closed
Kokaiinum opened this issue Sep 21, 2024 · 1 comment · Fixed by #79
Closed

Regression in 1.42: "Screen Effect/Viewport/Content/Sky/Pattern/Dropdown" doesn't exist in KK #78

Kokaiinum opened this issue Sep 21, 2024 · 1 comment · Fixed by #79
Labels
bug Something isn't working

Comments

@Kokaiinum
Copy link
Contributor

As the title says. 2ba9ed3 introduces some changes for dropdowns, but the element it clones for dropdowns, "Screen Effect/Viewport/Content/Sky/Pattern/Dropdown", is not present in KK. This causes an exception to be thrown when SceneEffectsCategory.Initialize() is run, and since that's not caught this breaks any plugin relying on it, such as StudioSceneSettings.
@Kokaiinum Kokaiinum added the bug Something isn't working label Sep 21, 2024
@ManlyMarco
Copy link
Collaborator

@krypto5863

krypto5863 added a commit to krypto5863/IllusionModdingAPI that referenced this issue Sep 21, 2024
@krypto5863
Should fix IllusionMods#78
f4fbf36
@ManlyMarco ManlyMarco linked a pull request Sep 21, 2024 that will close this issue
Should fix IllusionMods/IllusionModdingAPI#78 #79
Merged
ManlyMarco pushed a commit that referenced this issue Sep 21, 2024
@krypto5863
Should fix #78 (#79)
cd0d029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Should fix IllusionMods/IllusionModdingAPI#78 krypto5863/IllusionModdingAPI
2 participants
@ManlyMarco @Kokaiinum