fix(observable): preserve proxy invariants on get

Igmat · May 4, 2020 · 0c613ae · 0c613ae
1 parent 12300ca
commit 0c613ae
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/observable/src/observe.ts b/packages/observable/src/observe.ts
@@ -27,6 +27,11 @@ export function observeObj<T extends {}>(obj: T, onSet?: (tx: ITransaction) => v
     return new Proxy(obj, {
         // TODO: fix `symbol` type
         get(target, p: string | number, receiver) {
+            // preserving Proxy invariant
+            const desc = Reflect.getOwnPropertyDescriptor(target, p);
+            if (desc && !desc.configurable && !desc.writable) {
+                return Reflect.get(target, p, receiver);
+            }
             const atom = createAtomIfNotExists(p);
 
             return calculate(atom, () => Reflect.get(target, p, receiver), observe);