Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for xmlsec breaking when SHA1 is deprecated: Allow signature and digest algorithm as parameters ... #452

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomaswar
Copy link
Contributor

... for metadata generation. Also using sha256 as default to prevent xmlsec breaking on systems where sha1 is disabled.

Details

Pull allows for additional parameters --signature-algorithm and --digest-algorithm in scripts/saml_metadata.py which are applied when signing is true (the default).
Given Strings should reference xmldsig (mirroring frontend/backend configuration) like "SIG_RSA_SHA256".

Change of behavior

Defaults in scripts/saml_metadata.py select SHA256 instead of SHA1 (SHA1 is just the default in pysaml2) to avoid metadata generation breaking on systems where SHA1 is already deprecated and thus xmlsec1 unable to sign metadata. Which was the reason for the change in the first place (RHEL9).

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

… Also use sha256 as default to prevent breaking on systems with disabled sha1
@thomaswar thomaswar marked this pull request as draft January 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant