Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce SAML SP-initiated Logout to SATOSA proxy #431

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Introduce SAML SP-initiated Logout to SATOSA proxy #431

wants to merge 59 commits into from

Conversation

sebulibah
Copy link
Contributor

@sebulibah sebulibah commented Feb 15, 2023 •
edited by c00kiemon5ter
Loading

This PR introduces SAML Single Logout support for SATOSA. With this addition users will be able to log out of SAML Service Providers, improving security and user experience.

Changes

  • Register single_logout_service methods to endpoints
  • Register logout_callback functions
  • Add functions to handle logout requests and logout responses
  • Add a database to store session information required for logout

Testing

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@sebulibah
feat: register method to single_logout_service endpoints on saml fron…
5714885 
…tend
@sebulibah
feat: register logout callback functions
b260ba7
@sebulibah
feat: handle logout request on saml frontend
c680cef
@sebulibah
feat: create logout request on saml backend
b766961
@sebulibah
feat: build internal logout request
5dec525
@sebulibah
feat: add database for session storage
9800529
@sebulibah
feat: build saml backend logout request
48c0493
@sebulibah
feat: register single_logout_service endpoints on saml backend
1f8c8f0
@sebulibah
feat: bind handle_logout_message to single_logout_service endpoint on…
29b73f8 
… saml frontend
@sebulibah
feat: handle logout response at saml backend
62483f3
@sebulibah
feat: add logout response handlers in saml frontend
d4d7120
@sebulibah
feat: create logout response for sp that initiates logout
97c0aa0
@sebulibah
feat: create logout requests for sps with participating sessions
8e21fe3
@sebulibah
feat: return response object on saml backend after handling logout re…
ed1a461 
…sponse
@sebulibah
feat: add postgres and dictionary state storage
0ec992e
@sebulibah
test: add logout arguments to satosa/frontends/test_saml2 to fix tests
fa18536
@sebulibah
test: add logout arguments to satosa/frontends/test_openid_connect to…
415b409 
… fix tests
@sebulibah
fix: add logout callback function to samlvirtualcofrontend class
1a9cf0d
@sebulibah
fix: add logout callback function to openid connect frontend module
2aaaf4c
@sebulibah
test: add logout arguments to satosa/backends/test_saml2 to fix tests
cead543
@sebulibah
test: add logout arguments to fix backend tests
f676b13
@sebulibah
fix: add logout callback arguments to backends
321be65
@sebulibah
fix: add logout argument to ping frontend
f908453
@sebulibah
test: add logout arguments to fix failing test
f4c8760
@sebulibah
fix: handle case where entity_id is None in start_logout
6358ade
@gunpuz gunpuz mentioned this pull request Aug 9, 2023
Open
@c00kiemon5ter c00kiemon5ter self-assigned this Sep 26, 2023
@sebulibah
Merge remote-tracking branch 'upstream/master' into feat_saml_sp_logout
7622bcf
@sebulibah
feat: make logout_callback optional for fontends and backends
df3bbd1
@sebulibah
fix: remove logout_callback function from backend constructors
3afae0b
@sebulibah
fix: remove logout_callback function from frontend constructors
7fa68c5
@sebulibah
test: remove unused parameter from backend test fixtures
2794b60
@sebulibah
fix: remove logout parameter from facebook backend
f747cb8
@sebulibah
test: make logout_callback_func optional for saml2 frontend
bfbbbca
@sebulibah
fix: move logout callback to the end in saml backend module
71f2af3
@sebulibah
fix: move logout callback to the end in saml frontend module class co…
c5f0228 
…nstructor
@sebulibah
fix: make logout callback argument optional
bdc6942
@sebulibah
feat: introduce proxy config parameter to enable slo and load databas…
b2ed22f 
…e conditionally
@sebulibah
fix: correct typo when deleting context
4f3906c
@sebulibah
feat: make logout request signing configurable for saml frontend and …
b4e0c66 
…backend
@sebulibah
fix: handle errors from SPs that don't support SLO during frontend pr…
b9c1a6b 
…opagation
@niheconomoum
Copy link

We presented this work at the 2023 Internet2 Technology Exchange.

@sbliven
Copy link

sbliven commented Jun 27, 2024

This looks pretty far along. What's blocking the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c00kiemon5ter c00kiemon5ter

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebulibah @niheconomoum @sbliven @c00kiemon5ter