Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify api version #21

Open
eldesh opened this issue Nov 15, 2018 · 1 comment
Open

specify api version #21

eldesh opened this issue Nov 15, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@eldesh
Copy link
Collaborator

eldesh commented Nov 15, 2018

Dockworker uses / as the base path. So the latest version of api is used.
But now, only v1.26 is officialy supported. (bound of resource of @eldesh)

  • Add fix version api (at least)
  • Check version with using /version (or /_ping ?) .
  • Separate types with api version (how to abstract ?)
    • mod::v1_26::create_image or any other style
@bonotake bonotake mentioned this issue Feb 7, 2019
Closed
bonotake added a commit to bonotake/dockworker that referenced this issue Feb 7, 2019
@bonotake
workaround to avoid eldesh/dockworker's Issue Idein#21, Idein#31
9b104bc
@eldesh
Copy link
Collaborator Author

eldesh commented Feb 21, 2019

At least, reflect the value of the DOCKER_API_VERSION (https://docs.docker.com/develop/sdk/).

@eldesh eldesh added the enhancement New feature or request label Feb 21, 2019
@edigaryev edigaryev mentioned this issue Jun 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify API version when querying Docker API
1 participant
@eldesh