Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LizardReport unit test #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2019

Fix a space issue for lizardReport. This is a simplified PR of #180 and #184

bcolvin added a commit to bcolvin/sonar-swift that referenced this pull request Mar 20, 2019
ghost pushed a commit to volvogroup-mobility/sonar-swift that referenced this pull request May 23, 2019
* commit '794c8f4ef76ee559a1af5f34cbbbc5943ca65503':
  fix for cast exception
  licensing format
  update version
  update
  thanks @timothy-volvoIdean#207
  version change
  thanks tim
  imports
  imports
  merged pull request code from main
  fix a space issue for lizardReport
  revert directory stream to original and keep sensors consistent

# Conflicts:
#	commons/pom.xml
#	commons/src/main/java/com/backelite/sonarqube/commons/surefire/SurefireSensor.java
#	objclang/pom.xml
#	objclang/src/main/java/com/backelite/sonarqube/objectivec/ObjectiveCSquidSensor.java
#	objclang/src/main/java/com/backelite/sonarqube/objectivec/issues/oclint/OCLintParser.java
#	pom.xml
#	sonar-swift-plugin/pom.xml
#	sonar-swift-plugin/src/main/java/com/backelite/sonarqube/swift/complexity/LizardReportParser.java
#	sonar-swift-plugin/src/test/resources/lizard-report.xml
#	swiftlang/pom.xml
#	swiftlang/src/main/java/com/backelite/sonarqube/swift/SwiftSquidSensor.java
#	swiftlang/src/main/resources/org/sonar/plugins/swiftlint/profile-swiftlint.xml
#	swiftlang/src/main/resources/org/sonar/plugins/swiftlint/rules.json
@gaelfoppolo
Copy link
Collaborator

Please fix the conflicts before any review.

@gaelfoppolo
Copy link
Collaborator

Thank you @timothy-volvo, really appreciate your work!
Can you update your PR title and description? Looks like you're adding a unit test, not fixing an issue.

@ghost ghost changed the title Fix/lizard space issue Add LizardReport unit test Aug 26, 2019
@ghost
Copy link
Author

ghost commented Aug 26, 2019

@gaelfoppolo, title updated.

@gaelfoppolo
Copy link
Collaborator

@davidy4ng could you quickly review this?

@tthbalazs
Copy link

Quite an old PR, but this still seems to be an issue. Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants