Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDX-4551 Support xlsx Device Resource tags conversion #235

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

lindseysimple
Copy link
Contributor

Support xlsx Device Resource tags conversion.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Support xlsx Device Resource tags conversion.

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Update convertCellToAny func to parse string to a 64 bit integer and add unit tests.

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
@lindseysimple
Copy link
Contributor Author

@cloudxxx8 Change has been made to convert string to a 64 bit integer directly, thanks.

Copy link
Contributor

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit eb0e0a7 into v2.3-branch Jan 29, 2024
2 checks passed
@cloudxxx8 cloudxxx8 deleted the EDX-4551-branch branch January 29, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants