Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS-547 Add reuseable function for parsing DBC file to Device and DeviceProfile #209

Merged
merged 1 commit into from
Nov 13, 2023
Merged

PS-547 Add reuseable function for parsing DBC file to Device and DeviceProfile #209

merged 1 commit into from
Nov 13, 2023

Conversation

FelixTing
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

go.einride.tech/can v0.7.0

@FelixTing FelixTing marked this pull request as draft November 10, 2023 02:07
@FelixTing FelixTing force-pushed the PS-547-branch branch 2 times, most recently from e2d3d3c to abf957c Compare November 10, 2023 05:35
@FelixTing FelixTing marked this pull request as ready for review November 10, 2023 07:46
cloudxxx8
cloudxxx8 requested changes Nov 13, 2023
View reviewed changes
central/dbc/compile.go Outdated Show resolved Hide resolved
@FelixTing FelixTing force-pushed the PS-547-branch branch 2 times, most recently from 3598c85 to 2fd0327 Compare November 13, 2023 02:23
cloudxxx8
cloudxxx8 requested changes Nov 13, 2023
View reviewed changes
central/dbc/transform.go Outdated Show resolved Hide resolved
central/dbc/transform.go Outdated Show resolved Hide resolved
@FelixTing
PS-547 Add reuseable function for parsing DBC file to Device and Devi…
3a6ae09 
…ceProfile

Signed-off-by: FelixTing <felix@iotechsys.com>
@FelixTing
Copy link
Contributor Author

Added DTO validation and return errors in a similar way to the Excel Converter

cloudxxx8
cloudxxx8 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 2924f89 into v2.3-branch Nov 13, 2023
2 checks passed
@cloudxxx8 cloudxxx8 deleted the PS-547-branch branch November 13, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixTing @cloudxxx8