KGCL prototype library and webapp #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmungall
reviewed
Jul 29, 2021
parser/parser.py
Outdated
| command = tree.data | ||
| #print("Command: " + command) | ||
|
|
||
| if(command == "rename"): |
There was a problem hiding this comment.
minor: can we write this as more idiomatic python. @jamesaoverton do you have a preferred linter - flake8, black, ..?
There was a problem hiding this comment.
flake8 and black are good for different things, so Knocean usually uses both. @ckindermann please follow https://github.com/knocean/practises/tree/master/python#style and ask me if you have any questions.
There was a problem hiding this comment.
@jamesaoverton will do!
cmungall
reviewed
Jul 29, 2021
parser/parser.py
Outdated
| if(replacement_id_list): | ||
| t = next(replacement_id) | ||
| replacement_token = next(get_tokens(t)) | ||
| return python.kgcl.NodeObsoletion(id=id, about_node=label_token, has_direct_replacement=replacement_token) |
There was a problem hiding this comment.
minor: we should fix imports, should be either
from kgcl import NodeObsoletion, ...
...
return NodeObsoletion(...
or perhaps
import kgcl
...
return kgcl.NodeObsoletion(...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a bare-bones Flask application that shows how I instantiate classes in the KGCL data model for testing purposes.
https://kgcl.ontodev.com/