Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge devel with master branch #49

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Merge devel with master branch #49

wants to merge 69 commits into from

Conversation

cbouy
Copy link
Member

@cbouy cbouy commented Oct 19, 2019

No description provided.

cbouy and others added 30 commits October 3, 2018 17:51
…ly applies to a this place at DockFlow: "Continue [y/n]".
… was a huge bottleneck for large libraries.

The ineficiency came from .mol2 file checking AND "grep" the same file over and over, a huge problem especially over Network file systems (clusters and HPC).

In my desktop it took:
~800 ligands - 1m 30s to compute
~30000 took  > 5 minutes

@mazinger it took:
~800 ligands - 5m 30s to compute
~30000 took  > 15 minutes

This new implementation is orders of magnitude faster for two reasons:
1 - ChemBase and previous computed are stored in arrays. No more "grep".
2 - "for loops" were replaced by single line "case", which was amazingly faster.
…ces. It's LigFlow folder is already named "resp" (bcc, gas, original..) to simplify the naming schema.
…mol2" already existed. Now if it's there already we delete it first.
…f it wasn't asked to

This is noticeable when running --resp and --bcc at the same time, meaning that the file "LigFlow.xargs" or "LigFlow_bcc.xargs" may exist
… to "16" (NC_CHANGED) everytime "-nc" was evoked.
…ion was incorrect. I forgot to list ONLY ".mol2" files in the output folder
Also a bugFix for LigFlow when running on SLURM Gaussian, now each ligand will run on it's temporary folder.
The code may be clarifyed if we replace all the "mkdir -p blabla ; cd /tmp/blabla ; antechamber... " by a function.
@cbouy cbouy self-assigned this Oct 19, 2019
@cbouy
Copy link
Member Author

cbouy commented Oct 19, 2019

I'll update and run the tests before merging

@cbouy cbouy removed their assignment May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants