Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Pyro v2 #6

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Update to Pyro v2 #6

wants to merge 33 commits into from

Conversation

Ryomen-Sukuna
Copy link
Member

No description provided.

Ryomen-Sukuna and others added 2 commits September 20, 2022 17:09
Co-authored-by: Sourcery AI <58596630+sourcery-ai[bot]@users.noreply.github.com>
@IDN-C-X IDN-C-X deleted a comment from sourcery-ai bot Sep 24, 2022
Signed-off-by: Ryomen-Sukuna <ryomensukuna@anomali.eu.org>
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 24, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 4.69 ⭐ 4.62 ⭐ -0.07 👍
Method Length 89.10 🙂 94.06 🙂 4.96 👎
Working memory 9.27 🙂 9.35 🙂 0.08 👎
Quality 61.78% 🙂 61.58% 🙂 -0.20% 👎
Other metrics Before After Change
Lines 864 1002 138
Changed files Quality Before Quality After Quality Change
gdrive/init.py 45.05% 😞 45.00% 😞 -0.05% 👎
gdrive/main.py 63.27% 🙂 59.35% 🙂 -3.92% 👎
gdrive/config.py 52.53% 🙂 52.49% 🙂 -0.04% 👎
gdrive/helpers/downloader.py 75.99% ⭐ 74.32% 🙂 -1.67% 👎
gdrive/helpers/utils.py 83.15% ⭐ 83.20% ⭐ 0.05% 👍
gdrive/helpers/gdrive_utils/init.py % % %
gdrive/helpers/gdrive_utils/gDrive.py 59.55% 🙂 59.73% 🙂 0.18% 👍
gdrive/helpers/sql_helper/init.py 93.81% ⭐ 93.77% ⭐ -0.04% 👎
gdrive/helpers/sql_helper/gDriveDB.py 89.50% ⭐ 89.53% ⭐ 0.03% 👍
gdrive/helpers/sql_helper/idsDB.py 88.78% ⭐ 88.74% ⭐ -0.04% 👎
gdrive/plugins/authorize.py 60.99% 🙂 59.24% 🙂 -1.75% 👎
gdrive/plugins/copy.py 67.20% 🙂 67.20% 🙂 0.00%
gdrive/plugins/delete.py 58.55% 🙂 59.80% 🙂 1.25% 👍
gdrive/plugins/download.py 46.58% 😞 46.58% 😞 0.00%
gdrive/plugins/help.py 81.84% ⭐ 81.84% ⭐ 0.00%
gdrive/plugins/set_parent.py 44.98% 😞 44.98% 😞 0.00%
gdrive/plugins/utils.py 75.85% ⭐ 75.70% ⭐ -0.15% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdrive/plugins/download.py _download 10 🙂 284 ⛔ 10 😞 44.07% 😞 Try splitting into smaller methods. Extract out complex expressions
gdrive/plugins/download.py _telegram_file 5 ⭐ 229 ⛔ 14 😞 44.87% 😞 Try splitting into smaller methods. Extract out complex expressions
gdrive/plugins/set_parent.py _set_parent 12 🙂 179 😞 12 😞 44.98% 😞 Try splitting into smaller methods. Extract out complex expressions
gdrive/helpers/gdrive_utils/gDrive.py GoogleDrive.checkFolderLink 10 🙂 176 😞 13 😞 45.47% 😞 Try splitting into smaller methods. Extract out complex expressions
gdrive/helpers/gdrive_utils/gDrive.py GoogleDrive.upload_file 10 🙂 234 ⛔ 10 😞 46.44% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants