Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): upgrade vulnerable dependency #20

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Conversation

brackendawson
Copy link
Member

@brackendawson brackendawson commented Dec 30, 2022

Signed-off-by: Bracken Dawson abdawson@gmail.com

PR summary

jsonwebtoken was found to be vulnerable.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

jsonwebtoken was found to be vulnerable.

Signed-off-by: Bracken Dawson <abdawson@gmail.com>
The ibm-cloud-sdk-core now requires >=14

Signed-off-by: Bracken Dawson <abdawson@gmail.com>
Copy link

@Kieran-Muller Kieran-Muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Makes sense to upgrade to node 14 with the sdk removing support lower versions in order to patch vulnerabilities.

@brackendawson brackendawson merged commit c2ae04c into main Dec 30, 2022
@brackendawson brackendawson deleted the jsonwebtoken branch December 30, 2022 14:22
@ibm-reggie
Copy link
Collaborator

🎉 This PR is included in version 0.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants