Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switching to TypeScript #23

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

IAreKyleW00t
Copy link
Owner

@IAreKyleW00t IAreKyleW00t commented Sep 6, 2024

Why?

TypeScript gives us more control over the logic of setting up regctl, such as better validation and error handling. The biggest reason is to properly utilize a Runners built-in hostedtoolcache, which will automatically cache the regctl binary across runs without the need for additional upload/downloads like the normal actions/cache Action does. In addition to this, a much more thorough test suite is written for both the code and Action itself.

While these changes don't make the biggest difference for a tool as small as regctl, but we should still align to best practices when it comes to setting up runner tooling.

v1 and v2 will be maintained for critical issues.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@IAreKyleW00t IAreKyleW00t force-pushed the refactor/typescript branch 6 times, most recently from a67946b to 0639050 Compare September 7, 2024 14:55
@IAreKyleW00t IAreKyleW00t merged commit a09c9c0 into main Sep 7, 2024
27 checks passed
@IAreKyleW00t IAreKyleW00t deleted the refactor/typescript branch September 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant