Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide contracting category documents from restricted users #4136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Sep 17, 2024

Fixes #4119

image

Test Steps

  • Add restricted users' groups in Contractcategory section in admin.
  • Check if those users have access to view the document.

@frjo
Copy link
Contributor

frjo commented Sep 17, 2024

Adding all the roles with checkboxes is great for flexibility. But seeing it I start to think it would be better to reverse the logic.

"Allow document access to these groups:"

"Only selected groups will have document access."

Can we also list only Staff, Staff Admin, Finance and Contracting as options? Maybe it would be good to add this list of groups to hypha/apply/users/groups.py as "GROUPS_ORG_FACULTY" so we can reference it in other places?

By default we can then have all groups in this list checked.

@sandeepsajan0
Copy link
Member Author

image

image

image

@sandeepsajan0
Copy link
Member Author

@frjo It is ready for testing.

@frjo frjo added Status: Needs testing Tickets that need testing/qa Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team Status: Needs testing Tickets that need testing/qa Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide tax forms/banking info from staff, only showing finance/admins
2 participants