Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 'Add manual task' feature #4065
Implement 'Add manual task' feature #4065
Changes from all commits
1aceeac
52ea82a
7d5f9d1
f01b744
2039e33
a8824e0
f947a84
64dd5c1
248dc80
2f226a0
67bc904
2d94490
ba175cb
1b11c74
9f8f0bf
d663244
0c20039
21ae357
b662b37
7f0baff
d1b066e
3688cea
8da5eab
dec05e4
17d8f05
0b94d26
bb2e2b7
b27afa1
15409f9
7e61895
d194004
9d8f121
64b6aa6
453587f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull the message from the related item (i.e. the comment/activity object) itself? Maybe I'm missing something but it would better not to de-duplicate the message, as they can be edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think comment edited case should be handled but a separate task message can provide us flexibility in changing the language of the task message, it might be helpful later or in another kind of tasks. And duplicity in terms of storage shouldn't be an issue as these tasks are temporary and will be removed regularly.