Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status update batch action to invoices table #3756

Merged
merged 7 commits into from
Mar 30, 2024

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Feb 7, 2024

Description

Fixes part of #3537

image

Test Steps

  • Invoices table should be accessible to staff and finance
  • Staff and Finance both should have the option to select the invoices and update their statuses(depending on their statuses)
  • Check the statuses order like finance shouldn't be able to paid an invoice that is not Approved by finance yet.
  • Play around and provide your feedback.

@sandeepsajan0 sandeepsajan0 changed the title Add invoice status update batch action to invoices table Add status update batch action to invoices table Feb 7, 2024
@sandeepsajan0 sandeepsajan0 force-pushed the feature/invoice-batch-actions branch 2 times, most recently from ecd8260 to c369f43 Compare February 8, 2024 04:41
@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Patch Mini change, used in release drafter labels Feb 9, 2024
@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review February 14, 2024 12:09
@frjo frjo added the Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team label Feb 15, 2024
@frjo frjo force-pushed the feature/invoice-batch-actions branch from 3bafd45 to b793e3c Compare February 22, 2024 10:29
@frjo frjo added the Status: Needs testing Tickets that need testing/qa label Mar 4, 2024
@wes-otf
Copy link
Contributor

wes-otf commented Mar 10, 2024

In testing when there were two invoices that had the status Paid, selecting both of these and attempting updating the status to Payment failed results in a 500 with:

sequence item 0: expected str instance, NoneType found

At activity_feed.py. More info in sentry but it still seems to update the status. Seemed also specific to these statuses as others would update w/o issue. This was done as the finance role.

@wes-otf wes-otf added Status: Tested - changes/discussion needed 🔨 and removed Status: Needs testing Tickets that need testing/qa Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team labels Mar 10, 2024
@sandeepsajan0
Copy link
Member Author

@frjo Its latest version is ready to put on test.
@wes-otf There were issues with older invoices because we added invoice_number recently to the invoice model and as nobody was using the project/invoices so we didn't handle it for the older ones and let it None.
image

Although this was working fine for invoices with invoice_number so it wouldn't make any issue on prod still I have added a check to resolve this issue for older invoices as well.
It seems working fine now, you may try it again after the latest code deployment.

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Tested - changes/discussion needed 🔨 labels Mar 12, 2024
@wes-otf
Copy link
Contributor

wes-otf commented Mar 21, 2024

For some reason now whenever I go to /apply/projects/invoices/ on test I get a 500 page cause by the error:

Missing staticfiles manifest entry for 'js/apply/jquery.fancybox.min.js'

Which is weird, was there an issue with collectstatic on the deploy or something?

@frjo frjo force-pushed the feature/invoice-batch-actions branch from 4f4aed7 to bc2e20f Compare March 22, 2024 07:44
@frjo
Copy link
Contributor

frjo commented Mar 22, 2024

@wes-otf I missed doing a rebase for this PR, we have recently flatten the dir structure in another PR.

Should be fixed now.

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Mar 29, 2024
@frjo frjo merged commit 010eb2b into main Mar 30, 2024
10 checks passed
wes-otf pushed a commit that referenced this pull request Apr 1, 2024
wes-otf pushed a commit to OpenTechFund/apply-app that referenced this pull request Apr 1, 2024
wes-otf pushed a commit to OpenTechFund/apply-app that referenced this pull request Apr 1, 2024
@theskumar theskumar deleted the feature/invoice-batch-actions branch April 1, 2024 18:55
wes-otf pushed a commit that referenced this pull request May 7, 2024
wes-otf pushed a commit that referenced this pull request May 8, 2024
Vldln pushed a commit to equalitie/hypha that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Feature This is something new (not an enhancement of an existing thing). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants