Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes noticed during user testing(part-1) #3450

Merged
merged 10 commits into from
Jul 25, 2023
Merged

Fixes noticed during user testing(part-1) #3450

merged 10 commits into from
Jul 25, 2023

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Jun 21, 2023 •
edited
Loading

Refs: #3448

  • PAF waiting for approval table shouldn't show if no project in any tab.
  • Show requested by as well in PAF Approvals(sidebar). Right now only Pending and Approved are showing.
  • Show activities on the Invoice page.
  • Remove converted status from Invoices.
  • Format price to US format(configurable via settings)
  • "Add Invoice' as next step even after invoice creation(remove next step after one invoice).
  • Add section id to comments and use those for scrolling(request change comments)

frjo
frjo reviewed Jun 24, 2023
View reviewed changes
hypha/settings/base.py Outdated
@@ -20,7 +20,8 @@
# Hypha custom settings

# Set the currency symbol to be used.
CURRENCY_SYMBOL = env.str('CURRENCY_SYMBOL', '$')
CURRENCY_CODE = env.str('CURRENCY_CODE', 'USD')
LOCALE = env.str('LOCALE', 'en_US')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only used for currency should we call it CURRENCY_LOCALE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think for other places we can use LANGUAGE_CODE only currency needs to be strict so I'll rename it.

Copy link
Member Author

@sandeepsajan0 sandeepsajan0 Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or can't we just use LANGUAGE_CODE for currency as well(as @theskumar suggests)? It is also a similar setting and fixed for an organization. Or it might create any differences/issues?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frjo @sandeepsajan0 please take a look at my comment here: #3448 (comment)

theskumar
theskumar reviewed Jun 24, 2023
View reviewed changes
hypha/settings/base.py Outdated
@@ -20,7 +20,8 @@
# Hypha custom settings

# Set the currency symbol to be used.
CURRENCY_SYMBOL = env.str('CURRENCY_SYMBOL', '$')
CURRENCY_CODE = env.str('CURRENCY_CODE', 'USD')
LOCALE = env.str('LOCALE', 'en_US')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend picking this locale value from the LANGUAGE_CODE setting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is logical but have some practical issues.

LANGUAGE_CODE specifies what locales files to read translations from. So for no one has translated Hypha into another language as far as I know. What if they still want to pick another currency?

@theskumar
Copy link
Member

Regarding currency setup see my comment at #3448 (comment)

@frjo frjo added Status: Needs testing Tickets that need testing/qa Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Jul 13, 2023
@frjo
Copy link
Contributor

frjo commented Jul 20, 2023

@sandeepsajan0 Can you please rebase this PR? It got some merge conflicts after I merged in all the approved PRs to main.

@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/testing-suggestions branch from d052f02 to 1765435 Compare July 21, 2023 10:17
@sandeepsajan0
Copy link
Member Author

@frjo I have rebased the PR, we can put it back on the test site.

@frjo frjo merged commit e9b8ff6 into main Jul 25, 2023
10 checks passed
@frjo frjo deleted the enhancement/testing-suggestions branch August 11, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo frjo left review comments

@theskumar theskumar theskumar left review comments

@abhiXII abhiXII Awaiting requested review from abhiXII

Assignees
No one assigned
Labels
Status: Needs testing Tickets that need testing/qa Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeepsajan0 @theskumar @frjo