Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plan for 1.1 #40

Open
cburgmer opened this issue Nov 16, 2014 · 6 comments
Open

Release plan for 1.1 #40

cburgmer opened this issue Nov 16, 2014 · 6 comments

Comments

@cburgmer
Copy link
Contributor

Anything we need to consider for releasing 1.1 and with that include #37 ?

@cesutherland
Copy link
Member

Ha ha, nope.

cesutherland added a commit that referenced this issue Nov 17, 2014
@cesutherland
Copy link
Member

I've looked it over... looks like we could use a new CLI runner for the browser spec. I was using jasmine-headless-webkit previously.

@cesutherland
Copy link
Member

The author of that has pointed us to http://karma-runner.github.io/0.12/index.html

Do you want to take a look at that? I've used Karma on several angular projects successfully. It has a phantomjs driver.

@cburgmer
Copy link
Contributor Author

I created a new branch for trying out karma.

There seems to be an issue with a bunch of tests running under PhantomJS and Safari (both using WebKit). I might find some time to look at it. This blocks running the tests in Karma.

@cburgmer
Copy link
Contributor Author

OK, I finally had a look at why karma was failing under PhantomJS and it turned out to be 3 unrelated issues. Fixed and pushed to the karma branch.

I'm still not a fan of karma, but it seems to work in the current setup.

@cburgmer
Copy link
Contributor Author

The test not.toImageDiffEqual should fail under IntegrationSpecRunner.html looks off, i.e. no image shown. I believe this used to work in the past so we might need to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants