This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Adding SlimerJS Support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple arguments
…it check on the crop rect forbidding negative area crops.
SlimerJS won't load resemble with this cross domain setting
…are not ideal but requirement for SlimerJS
|
This is great. The latest version of resemble.js seems to fix the issue you addressed with CORS, so I've updated it. I've also made some tweaks to make this work with bundled-for-windows .bat file. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds drop-in SlimerJS support to PhantomCSS - in part addresses #39. SlimerJS adds better support for webfonts, iconfonts etc.
You can now run the demo suite with
casperjs test demo/testsuite.js --engine=slimerjs.The main requirement of SlimerJS is the use of absolute paths. SlimerJS/PhantomCSS fails silently for me when it can't load files. So if SlimerJS fails like that, check the paths are right.
There's also a change to the resemble.js package to make the cross-domain setting optional which was also breaking SlimerJS... silently.
Tested with the SlimerJS 'Lightweight Edition 0.9.5' and Firefox 35.0.1, with 'application.ini' patched to allow this higher version number.