Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK dependencies and webpack build #98

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Update SDK dependencies and webpack build #98

merged 6 commits into from
Apr 11, 2023

Conversation

esme
Copy link
Contributor

@esme esme commented Apr 7, 2023

Description

Jira Ticket: CALL-3266

  • Serve and run specs using jasmine-browser-runner in place of Karma
  • Update and clean up SDK npm dependencies
  • Update webpack build

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage? Unit tests, Integration tests
Verified that changes work?
Expect Dependencies to Fail?

.eslintrc Show resolved Hide resolved
@esme
Copy link
Contributor Author

esme commented Apr 7, 2023

@alonso-cadenas Should we bump the npm version here?

@esme esme marked this pull request as ready for review April 7, 2023 20:27
@esme esme requested a review from a team as a code owner April 7, 2023 20:27
alonso-cadenas
alonso-cadenas previously approved these changes Apr 7, 2023
package.json Outdated Show resolved Hide resolved
@alonso-cadenas
Copy link
Collaborator

@alonso-cadenas Should we bump the npm version here?

@esme, I suggest publishing a beta version, then updating the existing demo to use it to test that everything works. Probably best to wait until Monday to publish a patch version and merge to master.

alonso-cadenas
alonso-cadenas previously approved these changes Apr 10, 2023
package.json Show resolved Hide resolved
@esme esme merged commit 62f5bf4 into master Apr 11, 2023
@esme esme deleted the sdk-dependencies branch April 11, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants