Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new configuration options into hotswap-agent-core #169

Merged
merged 2 commits into from
Jan 31, 2017

Conversation

lancethomps
Copy link
Contributor

-excludedClassLoaderPatterns: Comma separated list of class loaders to exclude from initialization, in the form of RegEx patterns.
-reloadCallback: Optional method to call (that can exist outside of Hotswap, ie in your own project) every time a class is reloaded.

-excludedClassLoaderPatterns: Comma separated list of class loaders to exclude from initialization, in the form of RegEx patterns.
-reloadCallback: Optional method to call (that can exist outside of Hotswap, ie in your own project) every time a class is reloaded.
@skybber
Copy link
Contributor

skybber commented Jan 29, 2017

Hi, first of all thanks for contribution! I would have some notes to your pull request:

  • excludedClassLoaderPatterns is quite OK, it seem there is really missing such mechanism in HA and would be helpful in some cases.
  • reloadCallback can be implemented simply in a plugin as custom solution. We prefer to keep the core minimalistic, therefore it can't be accepted.

Could you please change the PR by removing the reloadCallback? Thanks!

@lancethomps
Copy link
Contributor Author

Removed reloadCallback.

@skybber skybber merged commit cfb5772 into HotswapProjects:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants