Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line deleting ExtractionInformation #1476

Closed
tznind opened this issue Oct 31, 2022 · 0 comments · Fixed by #1477
Closed

Command line deleting ExtractionInformation #1476

tznind opened this issue Oct 31, 2022 · 0 comments · Fixed by #1477
Labels
bug Issues that highlight a piece of functionality that is not working as expected

Comments

@tznind
Copy link
Contributor

tznind commented Oct 31, 2022

Describe the bug
Possibly an interaction with the new Commit system. When running Delete ExtractionInformation you can get There is already an open DataReader associated with this Connection. Looks like there might be an error running the delete which results in ShowException being called before Commit transaction happens. Not sure why ShowException would try to create a CoreChildProvider though.

./rdmp Delete ExtractionInformation:patient_triage_score
2022-10-31 11:07:46.7939 INFO Dotnet Version:6.0.8 .
2022-10-31 11:07:46.8126 INFO RDMP Version:8.0.4.0 .
2022-10-31 11:07:48.0519 TRACE Running Command 'ExecuteCommandDelete' .
2022-10-31 11:07:48.1536 DEBUG Deleted,ExtractionInformation,51,patient_triage_score .
2022-10-31 11:07:48.2045 ERROR There is already an open DataReader associated with this Connection which must be closed first. .
2022-10-31 11:07:48.2055 INFO Fatal error occurred so returning -1 . System.InvalidOperationException: There is already an open DataReader associated with this Connection which must be closed first.
   at Rdmp.Core.CommandLine.Interactive.ConsoleInputManager.ShowException(String errorText, Exception exception) in D:\Repos\RDMP\Rdmp.Core\CommandLine\Interactive\ConsoleInputManager.cs:line 99
   at Rdmp.Core.CommandExecution.BasicActivateItems.GetChildProvider() in D:\Repos\RDMP\Rdmp.Core\CommandExecution\BasicActivateItems.cs:line 172
   at Rdmp.Core.CommandExecution.BasicActivateItems.Publish(IMapsDirectlyToDatabaseTable databaseEntity) in D:\Repos\RDMP\Rdmp.Core\CommandExecution\BasicActivateItems.cs:line 589
   at Rdmp.Core.CommandExecution.BasicActivateItems.PublishNearest(Object publish) in D:\Repos\RDMP\Rdmp.Core\CommandExecution\BasicActivateItems.cs:line 389
   at Rdmp.Core.CommandExecution.BasicActivateItems.DeleteWithConfirmation(IDeleteable deleteable) in D:\Repos\RDMP\Rdmp.Core\CommandExecution\BasicActivateItems.cs:line 422
   at Rdmp.Core.CommandExecution.AtomicCommands.ExecuteCommandDelete.ExecuteImpl() in D:\Repos\RDMP\Rdmp.Core\CommandExecution\AtomicCommands\ExecuteCommandDelete.cs:line 120
   at Rdmp.Core.CommandExecution.BasicCommandExecution.ExecuteWithCommit(Action toRun, String description, IMapsDirectlyToDatabaseTable[] trackObjects) in D:\Repos\RDMP\Rdmp.Core\CommandExecution\BasicCommandExecution.cs:line 563
   at Rdmp.Core.CommandExecution.AtomicCommands.ExecuteCommandDelete.Execute() in D:\Repos\RDMP\Rdmp.Core\CommandExecution\AtomicCommands\ExecuteCommandDelete.cs:line 89
   at Rdmp.Core.CommandExecution.CommandInvoker.ExecuteCommand(ConstructorInfo constructorInfo, CommandLineObjectPicker picker) in D:\Repos\RDMP\Rdmp.Core\CommandExecution\CommandInvoker.cs:line 295
   at Rdmp.Core.CommandExecution.CommandInvoker.ExecuteCommand(Type type, CommandLineObjectPicker picker) in D:\Repos\RDMP\Rdmp.Core\CommandExecution\CommandInvoker.cs:line 222
   at Rdmp.Core.CommandLine.Runners.ExecuteCommandRunner.RunCommand(String command) in D:\Repos\RDMP\Rdmp.Core\CommandLine\Runners\ExecuteCommandRunner.cs:line 113
   at Rdmp.Core.CommandLine.Runners.ExecuteCommandRunner.Run(IRDMPPlatformRepositoryServiceLocator repositoryLocator, IDataLoadEventListener listener, ICheckNotifier checkNotifier, GracefulCancellationToken token) in D:\Repos\RDMP\Rdmp.Core\CommandLine\Runners\ExecuteCommandRunner.cs:line 103
   at Rdmp.Core.CommandLine.RdmpCommandLineBootStrapper.Run(RDMPCommandLineOptions opts, IRunner explicitRunner, IRDMPPlatformRepositoryServiceLocator existingLocator) in D:\Repos\RDMP\Rdmp.Core\CommandLine\RdmpCommandLineBootStrapper.cs:line 153
   at Rdmp.Core.CommandLine.RdmpCommandLineBootStrapper.RunCmd(ExecuteCommandOptions opts, IRDMPPlatformRepositoryServiceLocator existingLocator) in D:\Repos\RDMP\Rdmp.Core\CommandLine\RdmpCommandLineBootStrapper.cs:line 104
   at Rdmp.Core.Program.<>c.<HandleArguments>b__6_10(ExecuteCommandOptions opts) in D:\Repos\RDMP\Tools\rdmp\Program.cs:line 118
   at CommandLine.ParserResultExtensions.MapResult[T1,T2,T3,T4,T5,T6,T7,T8,T9,T10,T11,TResult](ParserResult`1 result, Func`2 parsedFunc1, Func`2 parsedFunc2, Func`2 parsedFunc3, Func`2 parsedFunc4, Func`2 parsedFunc5, Func`2 parsedFunc6, Func`2 parsedFunc7, Func`2 parsedFunc8, Func`2 parsedFunc9, Func`2 parsedFunc10, Func`2 parsedFunc11, Func`2 notParsedFunc)
   at Rdmp.Core.Program.HandleArguments(String[] args, Logger logger) in D:\Repos\RDMP\Tools\rdmp\Program.cs:line 93
@tznind tznind added the bug Issues that highlight a piece of functionality that is not working as expected label Oct 31, 2022
tznind added a commit that referenced this issue Oct 31, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that highlight a piece of functionality that is not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant