Fixed bug with ExecuteCrossServerDatasetExtractionSource guid table…

… name pattern Fixes #1256
HicServices · Jun 24, 2022 · c5c3ede · c5c3ede
1 parent e5ae73c
commit c5c3ede
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Fixed user being able to edit filters of a frozen [ExtractionConfiguration]/[CohortIdentificationConfiguration]
+- Fixed bug with `ExecuteCrossServerDatasetExtractionSource` guid table name pattern [#1256](https://github.com/HicServices/RDMP/issues/1256)
 
 ## [7.0.13] - 2022-05-30
 

diff --git a/...e/DataExport/DataExtraction/Pipeline/Sources/ExecuteCrossServerDatasetExtractionSource.cs b/...e/DataExport/DataExtraction/Pipeline/Sources/ExecuteCrossServerDatasetExtractionSource.cs
@@ -7,6 +7,7 @@
 using System;
 using System.Collections.Generic;
 using System.Data;
+using System.Text.RegularExpressions;
 using System.Threading;
 using FAnsi.Discovery;
 using FAnsi.Discovery.QuerySyntax;
@@ -139,9 +140,10 @@ private string GetTableName()
                 if (string.IsNullOrWhiteSpace(TemporaryTableName))
                     return null;
 
-                var guid = Guid.NewGuid();
+                // add a g to avoid creating a table name that starts with a number (can cause problems and always requires wrapping etc... just bad)
+                var guid = "g" + Guid.NewGuid().ToString("N");                
 
-                return _tablename = TemporaryTableName.Replace("$g", guid.ToString("N"));
+                return _tablename = TemporaryTableName.Replace("$g", guid);
             }
         }