Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 8 and 9 card testing cases #93 #98

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Drop 8 and 9 card testing cases #93 #98

wants to merge 2 commits into from

Conversation

HenryRLee
Copy link
Owner

Since 8-card evaluator and 9-card evaluator had been deprecated, we no longer need to test these two cases in the test code.

@HenryRLee HenryRLee linked an issue May 3, 2024 that may be closed by this pull request
Resolve edge cases in test_dptables.py #93
Open
@HenryRLee HenryRLee requested a review from azriel1rf May 3, 2024 06:54
@azriel1rf
Copy link
Collaborator

Thanks for the PR. I think you might know but the TestSuitsTable in test_dptables.py validates the SUITS array in dptables.py.
Since the purpose of the test is to verify the SUITS array, we need to reconstruct the SUITS table simultaneously with the modifications to the tests.

@HenryRLee
Copy link
Owner Author

Yeah, let me clean up the table then. There are many cells generated for 8-card and 9-card. But we don't need them now.

@HenryRLee HenryRLee marked this pull request as draft May 3, 2024 11:00
@HenryRLee
Copy link
Owner Author

I think I need to put this on hold. Cleaning up the whole table has some risks without having a unit test covering the evaluation results. Currently, our Python test coverage is very small and all the test cases are fixed scenarios. We may miss some edge cases if not being careful.

@HenryRLee
Copy link
Owner Author

I'll make this PR depends on issue #99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azriel1rf azriel1rf Awaiting requested review from azriel1rf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve edge cases in test_dptables.py
2 participants
@HenryRLee @azriel1rf