[Design] #22-리뷰 작성 UI #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-j-h-c
approved these changes
Jul 14, 2022
|
|
||
| import BSImagePicker | ||
| import SnapKit | ||
| import Photos |
There was a problem hiding this comment.
p4;
photos는 내장 프레임워크이니 UIKit 위에 써주세용~
Comment on lines
+77
to
+79
| func setUI() { | ||
| setLineDot(view: addPhotoView, color: UIColor.helfmeTagGray, radius: 8) | ||
| } |
yungu0010
approved these changes
Jul 14, 2022
i-colours-u
approved these changes
Jul 14, 2022
Comment on lines
+67
to
+72
| let borderLayer = CAShapeLayer() | ||
| borderLayer.strokeColor = color.cgColor | ||
| borderLayer.lineDashPattern = [2, 2] | ||
| borderLayer.frame = view.bounds | ||
| borderLayer.fillColor = nil | ||
| borderLayer.path = UIBezierPath(roundedRect: view.bounds, cornerRadius: radius).cgPath |
|
|
||
| private lazy var deleteBtn: UIButton = { | ||
| let btn = UIButton() | ||
| btn.setImage(ImageLiterals.ReviewWrite.deletePhotoBtn, for: .normal) |
There was a problem hiding this comment.
setImage 했을때 이미지 크기는 괜찮았나여?!
setBackgroundImage 했을때랑 비교해서 어떤게 맞는건지 나중에 한번 체크해봐도 괜찮겠네요!! p5;
|
그 StarSlider 디벨롭에 merge 됐는데 - 한번 Pull 받아서 붙여서 다시 올리면 좋을것같아요!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
🚨 참고 사항
📸 스크린샷
📟 관련 이슈