Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #60 - 상세페이지 화면전환 및 팬제스쳐 기능 구현 #64

Merged
merged 6 commits into from
Jul 14, 2022

Conversation

L-j-h-c
Copy link
Member

@L-j-h-c L-j-h-c commented Jul 14, 2022

🔥 Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

상세페이지 화면전환 및 팬제스쳐 기능 구현

📸 MP4

ezgif com-gif-maker

📟 관련 이슈

@L-j-h-c L-j-h-c added Feat 새로운 기능 구현 🧑🏻‍💻Duno labels Jul 14, 2022
@L-j-h-c L-j-h-c self-assigned this Jul 14, 2022
Copy link
Member

@0lynny 0lynny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선배 수고 많으셨습니다 배워가여

Comment on lines 20 to 26
func loadTelephoneApp(phoneNumber: String) {
let number: String = phoneNumber.trimmingCharacters(in: ["!"])
if let url = NSURL(string: "tel://" + "\(number)"),
UIApplication.shared.canOpenURL(url as URL) {
UIApplication.shared.open(url as URL, options: [:], completionHandler: nil)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전화거는거 알아갑니다 ㅎㅎ 쑊쌱!

}
}

func loadNaverMapApp(myLocation: NameLocation, destination: NameLocation) {
Copy link
Member

@0lynny 0lynny Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5;
이건 진짜 멋지다...

private func presentFindDirectionSheet() {
let actionSheet = UIAlertController(title: "길 찾기", message: nil, preferredStyle: .actionSheet)

let kakaoAction = UIAlertAction(title: "카카오맵", style: UIAlertAction.Style.default, handler: { _ in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5;
style: .default로 하는건 어떨까요? 어떤게 더 좋은건지 모르지만요..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeuni01
좋은 의견 고마워요~ 추후 반영해 보겠습니다

Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우리 오늘 못잔다 ... 화이팅 ! !

@L-j-h-c L-j-h-c merged commit 3832f3e into Health-Food-Me:develop Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑🏻‍💻Duno Feat 새로운 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 지도 UI 디테일 구현 및 상세뷰로 화면전환 로직 구현
3 participants