Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #285 - 상세 페이지 전체 메뉴판 API 연결 #291

Merged
merged 6 commits into from
Sep 28, 2022
Merged

[Feat] #285 - 상세 페이지 전체 메뉴판 API 연결 #291

merged 6 commits into from
Sep 28, 2022

Conversation

yungu0010
Copy link
Member

🔥 Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • 상세 페이지에서 메뉴판 이미지 띄우기
  • 메뉴판 이미지 유무에 따라 section 개수 분기처리

🚨 참고 사항

  • 데이터가 안 뜨는 식당이 있었는데 데이터가 없어서 나오지 않았던 것 같습니다..!
  • 메뉴판 이미지가 없을 때 컬렉션뷰 셀이 잘려서 보여 레이아웃 재조정이 필요할 것 같습니다.
식당 로그 메뉴판 없을 때 레이아웃

📸 스크린샷

기능 스크린샷
메뉴판 이미지

📟 관련 이슈

@yungu0010 yungu0010 added Feat 새로운 기능 구현 🌈YunDol labels Sep 26, 2022
@yungu0010 yungu0010 self-assigned this Sep 26, 2022
L-j-h-c
L-j-h-c reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다잉~~ 사용하지 않는 print문들은 지워주시면 될 것 같아요!

L-j-h-c
L-j-h-c approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

0inn
0inn approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생티비 .. 이제 분기처리하러 가자 .. ♡

@yungu0010 yungu0010 merged commit 443fe4b into Health-Food-Me:develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0inn 0inn 0inn approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@i-colours-u i-colours-u Awaiting requested review from i-colours-u

@0lynny 0lynny Awaiting requested review from 0lynny

Assignees

@yungu0010 yungu0010

Labels
Feat 새로운 기능 구현 🌈YunDol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 상세 페이지 전체 메뉴판 API 연결
3 participants
@yungu0010 @0inn @L-j-h-c