[Feat] 메뉴탭에 메뉴판 전체보기 추가 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-j-h-c
approved these changes
Sep 1, 2022
Comment on lines
+233
to
+235
| let sectionType = SectionLayout.allCases[section] | ||
| let count : Int = sectionType == .menu ? menuData.count : 1 | ||
| return count |
| @@ -99,6 +105,9 @@ extension MenuTabVC { | |||
|
|
|||
| private func registerCell() { | |||
| MenuCellCVC.register(target: menuCV) | |||
| AllImageCVC.register(target: menuCV) | |||
| menuCV.register(ImageHeaderView.self, forSupplementaryViewOfKind: UICollectionView.elementKindSectionHeader, withReuseIdentifier: ImageHeaderView.identifier | |||
There was a problem hiding this comment.
p5;
별건 아니지만 reuseIdentifier 쓸 때 .className으로 넣어줄 수 있겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
메뉴탭에서 메뉴판 전체보기 추가
🚨 참고 사항
메뉴판 이미지와 메뉴판 이미지 클릭 시 확대되어 보이는 이미지들은 임시로 넣어뒀습니다. 서버 붙일때 수정하겠습니다~!
그리고..
질문이 있습니다 !
컬렉션뷰 헤더를 지정할때 모든 섹션에 "메뉴 전체보기" 라는 헤더가 생겨서 헤더 사이즈 지정하는 부분에서 menu section부분의 높이를 0으로 지정해서 안보이게 해두었는데 다른 좋은 방법이 없을까요? 도저히 모르겠습니다 ㅎㅎ
📸 스크린샷
용량이슈로 gif가 안올라가네요..
https://user-images.githubusercontent.com/75068759/187742929-7014a662-537c-4910-a1ea-58fc989831c6.MP4
📟 관련 이슈