[Feat] #14 - 소셜로그인 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titleImageView와 subtitleImageView의 이미지 설정
1. 애플로그인을 위한 함수 작성 2. setAddTarget함수를 통해 버튼 이벤트 적용 3. SwiftLint에 맞는 코드 수정
i-colours-u
reviewed
Jul 6, 2022
| static let kakaoLoginError = "카카오 로그인에 실패하였습니다." | ||
| static let appleLoginError = "애플 로그인에 실패하였습니다." | ||
| } | ||
|
|
There was a problem hiding this comment.
p5;
구조체 간에 한 줄 간격으로만 작성해주면 좋을것 같아요 ~!
Comment on lines
18
to
21
| lazy var titleImageView = UIImageView() | ||
| lazy var subtitleImageView = UIImageView() | ||
| lazy var kakaoLoginButton = UIButton() | ||
| lazy var appleLoginButton = UIButton() |
There was a problem hiding this comment.
p3;
Social LoginVC에서만 사용하는 UI요소이기 때문에 - private 형태로 선언해주세요!
Comment on lines
108
to
116
| func showKakaoLoginFailMessage() { | ||
| self.makeAlert(title: I18N.Alert.error, message: I18N.Auth.kakaoLoginError, okAction: nil, completion: nil) | ||
| } | ||
|
|
||
| func postSocialLoginData(socialToken: String, socialType: String) { | ||
|
|
||
| } | ||
|
|
||
| func appleLogin() { |
There was a problem hiding this comment.
p3;
여기서도 private 으로 접근제한자 처리하면 좋을것 같아요!
L-j-h-c
reviewed
Jul 6, 2022
| @@ -6,31 +6,39 @@ | |||
| // | |||
|
|
|||
| import UIKit | |||
| import KakaoSDKAuth | |||
| struct Auth { | ||
| static let kakaoLoginError = "카카오 로그인에 실패하였습니다." | ||
| static let appleLoginError = "애플 로그인에 실패하였습니다." | ||
| } |
| import UIKit | ||
|
|
||
| import SnapKit | ||
| import AuthenticationServices |
There was a problem hiding this comment.
p5;
처음이니까 초큼 깐깐하게 할게여... 알파벳 순서대로! ㅎㅎ
Comment on lines
31
to
70
| private func setUI() { | ||
| titleImageView.image = UIImage(named: "authTitle") | ||
| subtitleImageView.image = UIImage(named: "authSubtitle") | ||
|
|
||
| kakaoLoginButton.setTitle("카카오톡 아이디로 로그인", for: .normal) | ||
| kakaoLoginButton.setTitleColor(.black, for: .normal) | ||
|
|
||
| appleLoginButton.setTitle("애플 아이디로 로그인", for: .normal) | ||
| appleLoginButton.backgroundColor = UIColor.carrotBlack | ||
| } | ||
|
|
||
| private func setLayout() { | ||
| view.addSubviews(titleImageView, subtitleImageView, kakaoLoginButton, appleLoginButton) | ||
| titleImageView.snp.makeConstraints { make in | ||
| make.top.equalToSuperview().inset(270) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| subtitleImageView.snp.makeConstraints { make in | ||
| make.top.equalTo(titleImageView.snp.bottom).offset(15) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| kakaoLoginButton.snp.makeConstraints { make in | ||
| make.top.equalTo(subtitleImageView.snp.bottom).offset(100) | ||
| make.leading.trailing.equalToSuperview().inset(50) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| appleLoginButton.snp.makeConstraints {make in | ||
| make.top.equalTo(kakaoLoginButton.snp.bottom).offset(9) | ||
| make.leading.trailing.equalToSuperview().inset(50) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
| } | ||
|
|
||
| func setAddTarget() { | ||
| kakaoLoginButton.addTarget(self, action: #selector(doKakaoLogin), for: .touchUpInside) | ||
| appleLoginButton.addTarget(self, action: #selector(doAppleLogin), for: .touchUpInside) | ||
| } |
There was a problem hiding this comment.
p4;
요 친구들 extension 해서 바깥으로 빼주세요~~!
Comment on lines
+42
to
+65
| private func setLayout() { | ||
| view.addSubviews(titleImageView, subtitleImageView, kakaoLoginButton, appleLoginButton) | ||
| titleImageView.snp.makeConstraints { make in | ||
| make.top.equalToSuperview().inset(270) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| subtitleImageView.snp.makeConstraints { make in | ||
| make.top.equalTo(titleImageView.snp.bottom).offset(15) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| kakaoLoginButton.snp.makeConstraints { make in | ||
| make.top.equalTo(subtitleImageView.snp.bottom).offset(100) | ||
| make.leading.trailing.equalToSuperview().inset(50) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
|
|
||
| appleLoginButton.snp.makeConstraints {make in | ||
| make.top.equalTo(kakaoLoginButton.snp.bottom).offset(9) | ||
| make.leading.trailing.equalToSuperview().inset(50) | ||
| make.centerX.equalToSuperview() | ||
| } | ||
| } |
| appleLogin() | ||
| } | ||
| } | ||
|
|
L-j-h-c
approved these changes
Jul 7, 2022
0inn
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
🚨 참고 사항
📸 스크린샷
📟 관련 이슈