Skip to content

Commit

Permalink
Merge pull request RocketChat#333 from alexbrazier/feature/fix-build
Browse files Browse the repository at this point in the history
Fix PR build
  • Loading branch information
engelgabriel authored Jan 30, 2017
2 parents 6a27874 + 10ee98c commit 213df33
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ matrix:
services:
- docker
script:
- docker run --rm -v ${PWD}:/project -e GH_TOKEN=${GH_TOKEN} rocketchat/electron.builder /bin/bash -l -c "npm install && npm run release -- --x64 --ia32"
- docker run --rm -v ${PWD}:/project -e GH_TOKEN=${GH_TOKEN} -e TRAVIS_PULL_REQUEST=${TRAVIS_PULL_REQUEST} rocketchat/electron.builder /bin/bash -l -c "npm install && npm run release -- --x64 --ia32"
- os: osx
osx_image: xcode7.3.1
language: generic
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"devDependencies": {
"chai": "^3.5.0",
"electron": "^1.4.15",
"electron-builder": "^11.7.0",
"electron-builder": "^12.0.3",
"electron-mocha": "^3.3.0",
"gulp": "^3.9.1",
"gulp-batch": "^1.0.5",
Expand Down
5 changes: 5 additions & 0 deletions scripts/travis-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
sleep 3
fi

if [[ "$TRAVIS_PULL_REQUEST" != "false" ]]; then
# Disable macOS code signing on PR
export CSC_IDENTITY_AUTO_DISCOVERY=false
fi

node --version
npm --version

Expand Down

0 comments on commit 213df33

Please sign in to comment.