{FEC} Updated existing documents #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
requested review from
stevomatthews
and removed request for
stevomatthews
ethouris
added
[docs]
|
BLOCKS: #856 |
docs/API-functions.md
Outdated
| @@ -968,7 +968,7 @@ connection parties. | |||
|
|
|||
| #### SRT_REJ_FILTER | |||
|
|
|||
| The `SRTO_FILTER` option has been set differently on both connection | |||
| The `SRTO_PACKETFILTER` option has been set differently on both connection | |||
| parties (NOTE: this flag may not exist yet in this version). | |||
There was a problem hiding this comment.
Suggested change
| parties (NOTE: this flag may not exist yet in this version). | |
| parties (NOTE: this flag does not exist in versions prior to 1.3.x). |
docs/API.md
Outdated
| | --------------------- | ----- | ------- | ------ | ------ | -------- | ------- | | ||
| | `SRTO_PACKETFILTER` | 1.4.0 | pre | string | | | [...512]| | ||
|
|
||
| - **[SET]** - Setup the packet filter. The string must match appropriate syntax |
There was a problem hiding this comment.
Suggested change
| - **[SET]** - Setup the packet filter. The string must match appropriate syntax | |
| - **[SET]** - Set up the packet filter. The string must match the appropriate syntax |
srtcore/common.h
Outdated
| /// and with the statement that only the sign of the result matters. | ||
| /// That is, it returns a negative value if seq1 < seq2, | ||
| /// positive if seq1 > seq2, and zero if they are equal. | ||
| /// The only tolerable use of this function is only when you |
There was a problem hiding this comment.
Suggested change
| /// The only tolerable use of this function is only when you | |
| /// The only useful application of this function is when you |
There was a problem hiding this comment.
I'd prefer "correct application". The all other uses are not just "useless", but erroneous.
srtcore/common.h
Outdated
| /// That is, it returns a negative value if seq1 < seq2, | ||
| /// positive if seq1 > seq2, and zero if they are equal. | ||
| /// The only tolerable use of this function is only when you | ||
| /// compare two values and it works faster than seqoff, however |
There was a problem hiding this comment.
Suggested change
| /// compare two values and it works faster than seqoff, however | |
| /// compare two values and it works faster than seqoff. However |
srtcore/common.h
Outdated
| /// The only tolerable use of this function is only when you | ||
| /// compare two values and it works faster than seqoff, however | ||
| /// the result's meaning is only in its sign. DO NOT USE THE | ||
| /// VALUE for any other purpose and its not meant to be the |
There was a problem hiding this comment.
Suggested change
| /// VALUE for any other purpose and its not meant to be the | |
| /// VALUE for any other purpose. It is not meant to be the |
stevomatthews
approved these changes
Sep 5, 2019
added 9 commits
September 6, 2019 09:06
…lity set definition. Recorded SRT HS flags in the fields.
… current payload size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
((DON'T REVIEW BEFORE PARENT IS MERGED:
pf-fec-core-packetfilter-api))