-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{FEC} Updated existing documents #855
{FEC} Updated existing documents #855
Conversation
BLOCKS: #856 |
docs/API-functions.md
Outdated
@@ -968,7 +968,7 @@ connection parties. | |||
|
|||
#### SRT_REJ_FILTER | |||
|
|||
The `SRTO_FILTER` option has been set differently on both connection | |||
The `SRTO_PACKETFILTER` option has been set differently on both connection | |||
parties (NOTE: this flag may not exist yet in this version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parties (NOTE: this flag may not exist yet in this version). | |
parties (NOTE: this flag does not exist in versions prior to 1.3.x). |
docs/API.md
Outdated
| --------------------- | ----- | ------- | ------ | ------ | -------- | ------- | | ||
| `SRTO_PACKETFILTER` | 1.4.0 | pre | string | | | [...512]| | ||
|
||
- **[SET]** - Setup the packet filter. The string must match appropriate syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **[SET]** - Setup the packet filter. The string must match appropriate syntax | |
- **[SET]** - Set up the packet filter. The string must match the appropriate syntax |
srtcore/common.h
Outdated
/// and with the statement that only the sign of the result matters. | ||
/// That is, it returns a negative value if seq1 < seq2, | ||
/// positive if seq1 > seq2, and zero if they are equal. | ||
/// The only tolerable use of this function is only when you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// The only tolerable use of this function is only when you | |
/// The only useful application of this function is when you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer "correct application". The all other uses are not just "useless", but erroneous.
srtcore/common.h
Outdated
/// That is, it returns a negative value if seq1 < seq2, | ||
/// positive if seq1 > seq2, and zero if they are equal. | ||
/// The only tolerable use of this function is only when you | ||
/// compare two values and it works faster than seqoff, however |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// compare two values and it works faster than seqoff, however | |
/// compare two values and it works faster than seqoff. However |
srtcore/common.h
Outdated
/// The only tolerable use of this function is only when you | ||
/// compare two values and it works faster than seqoff, however | ||
/// the result's meaning is only in its sign. DO NOT USE THE | ||
/// VALUE for any other purpose and its not meant to be the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// VALUE for any other purpose and its not meant to be the | |
/// VALUE for any other purpose. It is not meant to be the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor suggestions.
…lity set definition. Recorded SRT HS flags in the fields.
… current payload size
((DON'T REVIEW BEFORE PARENT IS MERGED:
pf-fec-core-packetfilter-api
))