[core] Add a shared mutex class #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Enhancement
|
ethouris
reviewed
Jul 12, 2024
|
|
||
| Mutex m_Mutex; | ||
| int m_iCountRead; | ||
| bool m_bWriterLocked; |
There was a problem hiding this comment.
These two fields can be combined into one field. Please see /usr/include/c++/v1/shared_mutex.
Would be also nice that you use exactly the same public API as the standard one so that a prospective drop-in replacement with the standard one from C++17 can be done later.
There was a problem hiding this comment.
I thought about merging those two fields. I however felt that it would hurt readibility for a negligible memory and performance gain.
API has been changed to match the standard one
Improved syntax Changed lock/unlock functions name to match reference implementation Add unit tests for SharedMutex
maxsharabayko
requested changes
Jul 29, 2024
|
@yomnes0 |
maxsharabayko
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shared mutex class