Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Set ACK position based on RCV buffer first nonread seqno. #2931

Merged

Conversation

maxsharabayko
Copy link
Collaborator

This is an experimental proposal for issue #2881.

The CRcvBuffer::getFirstNonreadSeqNo() returns the sequence number of the first packet that cannot be read from the buffer. This includes the first missing packet and the first packet of a several packets long message, if not all packets of the message exist yet. Due to the latter case, the proposed solution is not accurate in a message mode of SRT when TSBPD is disabled. When TSBPD is enabled, a message must always be one packet long.

There is a broader rework of the RCV buffer in PR #2527. However it may not end up in v1.5.4 due to some testing already performed with the existing RCV buffer implementation. Therefore this PR may be considered a temporal fix of #2881 until #2527 is merged.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Apr 18, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 18, 2024
srtcore/buffer_rcv.h Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit 968c9f9 into Haivision:master Aug 2, 2024
12 checks passed
@maxsharabayko maxsharabayko deleted the hotfix/ack-pos-based-on-rcvbuf branch August 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant