Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refax: improve logging and code readability around specific logging #2511

Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Nov 1, 2022

Changes:

  1. Added formatting function for numbers used in CPacket::pack logging to make log information clearer.
  2. Put whole contents (previously too finegrained) of packet.cpp file under srt namespace
  3. In queue.cpp, shipped off the highrate logging facility to a separate function and simplified macro in order to improve readability of the CSndQueue::worker function.

@codecov-commenter
Copy link

Codecov Report

Merging #2511 (8ca63b1) into master (53735e1) will increase coverage by 0.00%.
The diff coverage is 39.21%.

@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   65.48%   65.49%           
=======================================
  Files          99       99           
  Lines       19698    19721   +23     
=======================================
+ Hits        12900    12916   +16     
- Misses       6798     6805    +7     
Impacted Files Coverage Δ
srtcore/queue.cpp 81.34% <ø> (+1.19%) ⬆️
srtcore/packet.cpp 45.94% <39.21%> (-6.53%) ⬇️
srtcore/buffer_snd.cpp 67.10% <0.00%> (-0.66%) ⬇️
srtcore/core.cpp 59.11% <0.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Nov 7, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 7, 2022
@maxsharabayko maxsharabayko merged commit 2fd1363 into Haivision:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants