Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix UDP RCV and SND buffer size settings #2162

Merged
merged 2 commits into from
Dec 1, 2021
Merged

[bug] Fix UDP RCV and SND buffer size settings #2162

merged 2 commits into from
Dec 1, 2021

Conversation

jlsantiago0
Copy link
Contributor

This resolves Solaris unit tests failures caused by srt::CChannel::setUDPSockOpt() calling setsockopt() which can return failure when attempting to increase the SND|RCV buffers in excess of the system maximums, but still sets the buffersize to the system max.

The unit tests now PASS and SRT now works in HVIORouter.

@jlsantiago0
Copy link
Contributor Author

Unit Test hangs part way through before this PR:

solaris-test.log

@jlsantiago0
Copy link
Contributor Author

Unit tests run successfully after this PR:

solaris2-test.log

@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Oct 12, 2021
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior labels Oct 12, 2021
@maxsharabayko maxsharabayko changed the title Fix solaris unit tests Fix UDP RCV and SND buffer size settings Oct 12, 2021
@jlsantiago0 jlsantiago0 changed the title Fix UDP RCV and SND buffer size settings [bug] Fix UDP RCV and SND buffer size settings Oct 12, 2021
@maxsharabayko maxsharabayko merged commit e5a1179 into Haivision:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants