-
Notifications
You must be signed in to change notification settings - Fork 145
Restrict all jobs to run only during the month of October. #706
Conversation
The last user should move from waiting to a completed state on Nov 14th at 10am UTC. Hacktoberfest also technically starts before October, so it might be simplest to just have all the jobs run for the duration of September, October and November. |
@MattIPv4 I've updated the code to restrict jobs between setp and nov. If you want a more sophisticated solution I could try, but I think you're right that this is the simplest. Other solutions that I can think of involve ruby code checking if there are any users waiting. That just cuts the job short, but doesn't actually prevent the job from running and wouldn't make it much more efficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@katjuell could you just sanity check this, that nothing needs to keep running outside these months? |
The only one I have questions about is the |
I think we should keep that job running with the others so that we aren't in a position where we might be suggesting lots of stale issues on the homepage. 👍 |
I left a comment on #711 regarding how we might frame/present issues once HF has ended, so that folks are not under the impression that work on these issues would count toward HF. Happy to continue the discussion over there, since it doesn't really have to do with this PR. |
👍 Agreed that we probably need to update the copy, can be discussed/done in #711 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR is meant to close issue #435. It restricts all jobs in the sidekiq schedule to the month of October. This will effectively stop all jobs when Hacktoberfest is over. It happens automatically (no manual work), and it can be used again in subsequent years without any code changes.
Test process
I have not tested this, beyond confirming the crons in a cron generator. I'm not sure how. I suppose it could be tested in a QA environment by changing the system time, or the month of the cron, but I'll leave that up to maintainers to decide.
Requirements to merge