-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
40e4c0c
to
b5c04e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Need @mkcode to approve.
Also, update the PR body description.
It might be worth storing the state the user went inactive from when we transition them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - we need to add the handler to the most important case - the UserTransitionJob
Ok. Let's address @johndbritton's concern as well. Let's add a |
9ddc096
to
ea0e178
Compare
Force push for rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missed adding this error handling to the TryUserTransitionJob
…fest into handle-github-errors
****PR moved to #431 |
Moved to #431
Description
Fixes #409
This PR consolidates error handling logic for the case when a user's account is suspended(
Octokit::AccountSuspended
) and when a user's account is missing from Github (GithubPullRequestService::UserNotFoundOnGithubError
). This sits in a new service object which gets passed a user and a block,GithubErrorHandler
.For both of these errors, we handle by deactivating the user, putting them in the
inactive
state (a new state on the state machine specifically for these users no longer accounted for in GitHub) and deleting their associatedUserStat
, if they have one.Test process
inactive
stateUserStat
is deleted, if they had oneRequirements to merge