Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling wrong data in input when Enter is press #946

Merged
merged 3 commits into from
Jul 13, 2017
Merged

Handling wrong data in input when Enter is press #946

merged 3 commits into from
Jul 13, 2017

Conversation

dbertella
Copy link
Contributor

Related to #945 I think the correct behaviour should be exactly as if you click outside when the data is wrong.
The input field keep the wrong data as it is and the implementer should handle the error if needed.

Let me know if you find this interesting and if there is anything else to do I can keep working on it.
date-picker-pr

@codecov-io
Copy link

codecov-io commented Jul 13, 2017

Codecov Report

Merging #946 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #946      +/-   ##
=========================================
+ Coverage   85.85%   85.9%   +0.04%     
=========================================
  Files          12      12              
  Lines         608     610       +2     
  Branches      119     120       +1     
=========================================
+ Hits          522     524       +2     
  Misses          3       3              
  Partials       83      83
Impacted Files Coverage Δ
src/datepicker.jsx 91.77% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072ee92...e73e456. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants