DD-272 Updating dependencies #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KLV96
force-pushed
the
DD-272-update-dependencies-and-move-to-node-22
branch
5 times, most recently
from
78ff57f
to
b12b515
Compare
KLV96
changed the title
KLV96
force-pushed
the
DD-272-update-dependencies-and-move-to-node-22
branch
from
b12b515
to
dc34daa
Compare
SamChatfield
requested changes
Sep 26, 2024
eslint.config.js
Outdated
| { | ||
| languageOptions: { | ||
| globals: { | ||
| module: 'readonly', |
There was a problem hiding this comment.
We can use the package globals as a devDependency to set up the Node globals same as what our internal ESLint config does instead of needing to define any individually
There was a problem hiding this comment.
This hasn't been resolved
eslint.config.js
Outdated
| }, | ||
| parserOptions: { | ||
| ecmaVersion: 2021, | ||
| sourceType: 'module', // This can stay as 'module' if you're using ES modules within CommonJS context. |
There was a problem hiding this comment.
We're still using CJS so don't want this yet
There was a problem hiding this comment.
This hasn't been resolved
eslint.config.js
Outdated
| }; | ||
|
|
||
| // Define the ESLint configuration | ||
| module.exports = defineConfig([ |
There was a problem hiding this comment.
We should base this on ESLint's recommended rules as it was before, see our internal ESLint config for how to do that.
There was a problem hiding this comment.
This hasn't been resolved
Drop Node 14, 16 and 18 and allowing only 20.x || 22.x and updating the following dependencies: debug ^4.3.4 -> ^4.3.7 glob ^10.4.5 -> ^11.0.0 eslint ^8.57.0 -> ^9.11.1 Adding eslint-define-config and replacing .eslintrc with eslint.config.js Adding Husky ^9.1.6 and mpo-node-standards ^2.0.0 then adding ./husky/pre-push nyc ^17.0.0 -> ^17.1.0 sinon ^18.0.0 -> ^19.0.2 globals ^15.9.0
KLV96
force-pushed
the
DD-272-update-dependencies-and-move-to-node-22
branch
from
dc34daa
to
556a9d1
Compare
|
Can we update the branch name so it's not specific to Node 22 as we support 20 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Node 14, 16 and 18 and allowing only 20.x || 22.x and updating the following dependencies:
debug ^4.3.4 -> ^4.3.7
glob ^10.4.5 -> ^11.0.0
eslint ^8.57.0 -> ^9.11.1
Adding eslint-define-config and replacing .eslintrc with eslint.config.js
Adding Husky ^9.1.6 and mpo-node-standards ^2.0.0 then adding ./husky/pre-push
nyc ^17.0.0 -> ^17.1.0
sinon ^18.0.0 -> ^19.0.2
globals ^15.9.0
mocha ^10.7.0 -> ^10.7.3